-
Notifications
You must be signed in to change notification settings - Fork 11
Add Cert Manager to Operator #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/provided-mode-test.md
Outdated
| @@ -0,0 +1,445 @@ | |||
| # Provided TLS mode: step-by-step test (AKV + Secrets Store CSI) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets put all tls setup doc under our /documentdb-playground/tls folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is improtant.
| @@ -0,0 +1,186 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets move all the TLS cert-manager scripts to the documentdb-playground/tls folder.
| done | ||
|
|
||
| if [[ -z "$RESOURCE_GROUP" ]]; then | ||
| RESOURCE_GROUP="guanzhou-${SUFFIX}-rg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have guanzhou hardcoded in many places. Please replace them with param or documentdb
|
We need a delete cluster or cleanup command to avoid cost. |
|
Here are my thoughts. Here we'll have a README or tls-setup.md file, which will give two simple commands maybe.
|
| @@ -0,0 +1,657 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new folder tls under /documentdb-playground and move all the scripts and docs under it.
| @@ -17,10 +17,10 @@ walReplica: false # Set to true to deploy the WAL replica plugin | |||
|
|
|||
| image: | |||
| documentdbk8soperator: | |||
| repository: ghcr.io/microsoft/documentdb-kubernetes-operator/operator | |||
| repository: ghcr.io/guanzhousongmicrosoft/documentdb-kubernetes-operator/operator | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the official registry name.
| pullPolicy: Always | ||
| sidecarinjector: | ||
| repository: ghcr.io/microsoft/documentdb-kubernetes-operator/sidecar | ||
| repository: ghcr.io/guanzhousongmicrosoft/documentdb-kubernetes-operator/sidecar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. Keep official repo name.
| Enabled: pointer.Bool(true), | ||
| Parameters: params, | ||
| }} | ||
| }(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase. We changed the directory structure.
| #set -e # Exit on any error | ||
|
|
||
| # Configuration | ||
| CLUSTER_NAME="guanzhou-102001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use documentdb- prefix instead of our usernames.
| # DocumentDB Operator Configuration | ||
| # For testing: use hossain-rayhan/documentdb-operator (fork with Azure enhancements) | ||
| # For production: use microsoft/documentdb-operator (official) | ||
| OPERATOR_GITHUB_ORG="guanzhousongmicrosoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default should be microsoft.
docs/provided-mode-test.md
Outdated
| @@ -0,0 +1,445 @@ | |||
| # Provided TLS mode: step-by-step test (AKV + Secrets Store CSI) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is improtant.
No description provided.